Discussion:
[dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd doc
(too old to reply)
Dekel Peled
2018-12-06 12:06:14 UTC
Permalink
testpmd actions set_tp_src and set_tp_dst documentation adds the
of_ prefix to action names, while the implementation doesn't add it.

This patch removes the prefix from action names in testpmd
documentation.

Fixes: 9ccc94919500 ("ethdev: add flow API actions to modify TCP/UDP port numbers")
Cc: ***@chelsio.com

Signed-off-by: Dekel Peled <***@mellanox.com>
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 056f8bb..9d4f107 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -3931,12 +3931,12 @@ This section lists supported actions and their attributes, if any.

- ``ipv6_addr``: New IPv6 destination address.

-- ``of_set_tp_src``: Set a new source port number in the outermost TCP/UDP
+- ``set_tp_src``: Set a new source port number in the outermost TCP/UDP
header.

- ``port``: New TCP/UDP source port number.

-- ``of_set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
+- ``set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
header.

- ``port``: New TCP/UDP destination port number.
--
1.8.3.1
Ori Kam
2018-12-06 12:15:26 UTC
Permalink
-----Original Message-----
Sent: Thursday, December 6, 2018 2:06 PM
Subject: [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd
doc
testpmd actions set_tp_src and set_tp_dst documentation adds the
of_ prefix to action names, while the implementation doesn't add it.
This patch removes the prefix from action names in testpmd
documentation.
Fixes: 9ccc94919500 ("ethdev: add flow API actions to modify TCP/UDP port numbers")
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 056f8bb..9d4f107 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -3931,12 +3931,12 @@ This section lists supported actions and their attributes, if any.
- ``ipv6_addr``: New IPv6 destination address.
-- ``of_set_tp_src``: Set a new source port number in the outermost TCP/UDP
+- ``set_tp_src``: Set a new source port number in the outermost TCP/UDP
header.
- ``port``: New TCP/UDP source port number.
-- ``of_set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
+- ``set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
header.
- ``port``: New TCP/UDP destination port number.
--
1.8.3.1
Acked-by: Ori Kam <***@mellanox.com>
Thanks,
Ori
Rahul Lakkireddy
2018-12-06 12:18:10 UTC
Permalink
Post by Dekel Peled
testpmd actions set_tp_src and set_tp_dst documentation adds the
of_ prefix to action names, while the implementation doesn't add it.
This patch removes the prefix from action names in testpmd
documentation.
Fixes: 9ccc94919500 ("ethdev: add flow API actions to modify TCP/UDP port numbers")
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 056f8bb..9d4f107 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -3931,12 +3931,12 @@ This section lists supported actions and their attributes, if any.
- ``ipv6_addr``: New IPv6 destination address.
-- ``of_set_tp_src``: Set a new source port number in the outermost TCP/UDP
+- ``set_tp_src``: Set a new source port number in the outermost TCP/UDP
header.
- ``port``: New TCP/UDP source port number.
-- ``of_set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
+- ``set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
header.
- ``port``: New TCP/UDP destination port number.
--
1.8.3.1
Good catch!

Acked-by: Rahul Lakkireddy <***@chelsio.com>

Loading...