Discussion:
[dpdk-dev] [PATCH 1/6] doc: add empty PMDs todo list
(too old to reply)
Ferruh Yigit
2017-11-21 01:42:36 UTC
Permalink
Some library modifications require extra checks or modifications in PMDs
but currently we don't have a good way to trace these modifications.

And number of these kind of updates increasing by time.

This is an effort to document and track library updates that requires
attention in PMDs.

Although this is under documentation main use case is for internal
development.

Signed-off-by: Ferruh Yigit <***@intel.com>
---
MAINTAINERS | 1 +
doc/guides/nics/index.rst | 1 +
doc/guides/nics/todo.rst | 43 +++++++++++++++++++++++++++++++++++++++++++
3 files changed, 45 insertions(+)
create mode 100644 doc/guides/nics/todo.rst

diff --git a/MAINTAINERS b/MAINTAINERS
index f0baeb423..c9eaff774 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -315,6 +315,7 @@ Networking Drivers
M: Ferruh Yigit <***@intel.com>
T: git://dpdk.org/next/dpdk-next-net
F: doc/guides/nics/features/default.ini
+F: doc/guides/nics/todo.rst

Link bonding
M: Declan Doherty <***@intel.com>
diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst
index 23babe933..f257fbd87 100644
--- a/doc/guides/nics/index.rst
+++ b/doc/guides/nics/index.rst
@@ -37,6 +37,7 @@ Network Interface Controller Drivers

overview
features
+ todo
build_and_test
ark
avp
diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
new file mode 100644
index 000000000..874811ad5
--- /dev/null
+++ b/doc/guides/nics/todo.rst
@@ -0,0 +1,43 @@
+.. BSD LICENSE
+ Copyright(c) 2017 Intel Corporation. All rights reserved.
+ All rights reserved.
+
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions
+ are met:
+
+ * Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+ * Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in
+ the documentation and/or other materials provided with the
+ distribution.
+ * Neither the name of Intel Corporation nor the names of its
+ contributors may be used to endorse or promote products derived
+ from this software without specific prior written permission.
+
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+PMDs internal TODO list
+=======================
+
+This is the list for tracking required PMD changes triggered by library modifications.
+
+.. table:: PMDs internal TODO list
+
+ +------+------+----------+----------------+------+
+ | TODO | PMDs | Deadline | Related Commit | Note |
+ +======+======+==========+================+======+
+ | | | | | |
+ +------+------+----------+----------------+------+
--
2.13.6
Ferruh Yigit
2017-11-21 01:42:37 UTC
Permalink
To track modification:
8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")

Proposed deadline for PMDs is v18.02

Signed-off-by: Ferruh Yigit <***@intel.com>
---
doc/guides/nics/todo.rst | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 874811ad5..b408fc691 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -36,8 +36,17 @@ This is the list for tracking required PMD changes triggered by library modifica

.. table:: PMDs internal TODO list

- +------+------+----------+----------------+------+
- | TODO | PMDs | Deadline | Related Commit | Note |
- +======+======+==========+================+======+
- | | | | | |
- +------+------+----------+----------------+------+
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | TODO | PMDs | Deadline | Related Commit | Note |
+ +===================+================================+==========+================+===================================+
+ | mbuf organisation | | af_packet, ark, avp, bnx2x, | v18.02 | 8f094a9ac5d7 | Remove unnecessary mbuf field |
+ | | | bnxt, bonding, cxgbe, dpaa, | | | initialization. |
+ | | | dpaa2, e1000, ena, | | | |
+ | | | failsafe, fm10k, | | | |
+ | | | kni, mlx4, | | | |
+ | | | mrvl, nfp, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
--
2.13.6
Marko Kovacevic
2017-12-11 14:00:06 UTC
Permalink
Post by Ferruh Yigit
8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
Proposed deadline for PMDs is v18.02
Acked-by:Marko Kovacevic<***@intel.com>
Mcnamara, John
2017-12-11 14:09:38 UTC
Permalink
-----Original Message-----
From: Yigit, Ferruh
Sent: Tuesday, November 21, 2017 1:43 AM
Subject: [PATCH 2/6] doc: add mbuf reorg to PMD todo list
8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
Proposed deadline for PMDs is v18.02
Acked-by: John McNamara <***@intel.com>
Andrew Rybchenko
2017-12-29 11:58:29 UTC
Permalink
Post by Ferruh Yigit
8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
Proposed deadline for PMDs is v18.02
---
doc/guides/nics/todo.rst | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 874811ad5..b408fc691 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -36,8 +36,17 @@ This is the list for tracking required PMD changes triggered by library modifica
.. table:: PMDs internal TODO list
- +------+------+----------+----------------+------+
- | TODO | PMDs | Deadline | Related Commit | Note |
- +======+======+==========+================+======+
- | | | | | |
- +------+------+----------+----------------+------+
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | TODO | PMDs | Deadline | Related Commit | Note |
+ +===================+================================+==========+================+===================================+
+ | mbuf organisation | | af_packet, ark, avp, bnx2x, | v18.02 | 8f094a9ac5d7 | Remove unnecessary mbuf field |
+ | | | bnxt, bonding, cxgbe, dpaa, | | | initialization. |
+ | | | dpaa2, e1000, ena, | | | |
+ | | | failsafe, fm10k, | | | |
+ | | | kni, mlx4, | | | |
+ | | | mrvl, nfp, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
sfc may be removed from the list since it has already been done.
Reference counter and number of segments are still set as part
of 64-bit rearm data, but I think it is rather a question of separate
performance investigation and optimization.
Of course, we can send a patch to remove from todo list with
explanations why.
Stephen Hemminger
2017-12-29 17:07:49 UTC
Permalink
On Tue, 21 Nov 2017 01:42:37 +0000
Post by Ferruh Yigit
8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
Proposed deadline for PMDs is v18.02
---
doc/guides/nics/todo.rst | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 874811ad5..b408fc691 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -36,8 +36,17 @@ This is the list for tracking required PMD changes triggered by library modifica
.. table:: PMDs internal TODO list
- +------+------+----------+----------------+------+
- | TODO | PMDs | Deadline | Related Commit | Note |
- +======+======+==========+================+======+
- | | | | | |
- +------+------+----------+----------------+------+
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | TODO | PMDs | Deadline | Related Commit | Note |
+ +===================+================================+==========+================+===================================+
+ | mbuf organisation | | af_packet, ark, avp, bnx2x, | v18.02 | 8f094a9ac5d7 | Remove unnecessary mbuf field |
+ | | | bnxt, bonding, cxgbe, dpaa, | | | initialization. |
+ | | | dpaa2, e1000, ena, | | | |
+ | | | failsafe, fm10k, | | | |
+ | | | kni, mlx4, | | | |
+ | | | mrvl, nfp, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
NAK

This open source, if the fix is trivial please just fix all the drivers directly now.
These TODO lists never get done.
Olivier Matz
2018-01-03 14:00:09 UTC
Permalink
Hi,
Post by Stephen Hemminger
On Tue, 21 Nov 2017 01:42:37 +0000
Post by Ferruh Yigit
8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
Proposed deadline for PMDs is v18.02
---
doc/guides/nics/todo.rst | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 874811ad5..b408fc691 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -36,8 +36,17 @@ This is the list for tracking required PMD changes triggered by library modifica
.. table:: PMDs internal TODO list
- +------+------+----------+----------------+------+
- | TODO | PMDs | Deadline | Related Commit | Note |
- +======+======+==========+================+======+
- | | | | | |
- +------+------+----------+----------------+------+
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | TODO | PMDs | Deadline | Related Commit | Note |
+ +===================+================================+==========+================+===================================+
+ | mbuf organisation | | af_packet, ark, avp, bnx2x, | v18.02 | 8f094a9ac5d7 | Remove unnecessary mbuf field |
+ | | | bnxt, bonding, cxgbe, dpaa, | | | initialization. |
+ | | | dpaa2, e1000, ena, | | | |
+ | | | failsafe, fm10k, | | | |
+ | | | kni, mlx4, | | | |
+ | | | mrvl, nfp, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
NAK
This open source, if the fix is trivial please just fix all the drivers directly now.
These TODO lists never get done.
The fix is not that trivial, especially for vector PMDs.
It can also impact performance.

It looks dangerous for me to blindly do a patch without any hardware to
do the test.
Ferruh Yigit
2017-11-21 01:42:38 UTC
Permalink
To track modification:
c1b5fa94a46f ("eal: support dynamic log types")

Proposed deadline for PMDs is v18.08

Signed-off-by: Ferruh Yigit <***@intel.com>
---
doc/guides/nics/todo.rst | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index b408fc691..973379a3d 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -50,3 +50,14 @@ This is the list for tracking required PMD changes triggered by library modifica
| | | thunderx, vhost, | | | |
| | | vmxnet3 | | | |
+-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | dynamic logging | | af_packet, ark, avp, bnx2x, | v18.08 | c1b5fa94a46f | Switch to dynamic logging |
+ | | | bnxt, bonding, cxgbe, dpaa, | | | functions, remove static debug |
+ | | | dpaa2, e1000, ena, enic, | | | config options. |
+ | | | failsafe, fm10k, ixgbe, | | | |
+ | | | kni, liquidio, mlx4, mlx5, | | | |
+ | | | mrvl, nfp, null, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, virtio, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
--
2.13.6
Hemant Agrawal
2017-12-08 05:12:21 UTC
Permalink
Post by Ferruh Yigit
c1b5fa94a46f ("eal: support dynamic log types")
Proposed deadline for PMDs is v18.08
---
doc/guides/nics/todo.rst | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index b408fc691..973379a3d 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -50,3 +50,14 @@ This is the list for tracking required PMD changes triggered by library modifica
| | | thunderx, vhost, | | | |
| | | vmxnet3 | | | |
+-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | dynamic logging | | af_packet, ark, avp, bnx2x, | v18.08 | c1b5fa94a46f | Switch to dynamic logging |
+ | | | bnxt, bonding, cxgbe, dpaa, | | | functions, remove static debug |
+ | | | dpaa2, e1000, ena, enic, | | | config options. |
+ | | | failsafe, fm10k, ixgbe, | | | |
+ | | | kni, liquidio, mlx4, mlx5, | | | |
+ | | | mrvl, nfp, null, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, virtio, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
One small correction - dpaa is already supporting dynamic logging.

It is a good idea to have todo item documented.

Series-acked-by: Hemant Agrawal <***@nxp.com>
Mcnamara, John
2017-12-11 14:09:53 UTC
Permalink
-----Original Message-----
From: Yigit, Ferruh
Sent: Tuesday, November 21, 2017 1:43 AM
Subject: [PATCH 3/6] doc: add dynamic logging to PMD todo list
c1b5fa94a46f ("eal: support dynamic log types")
Proposed deadline for PMDs is v18.08
Acked-by: John McNamara <***@intel.com>
Ferruh Yigit
2017-11-21 01:42:39 UTC
Permalink
To track modification:
b1b700ce7d6f ("ethdev: add descriptor status API")

Proposed deadline for PMDs is v19.02

Signed-off-by: Ferruh Yigit <***@intel.com>
---
doc/guides/nics/todo.rst | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 973379a3d..9ace19716 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -61,3 +61,14 @@ This is the list for tracking required PMD changes triggered by library modifica
| | | thunderx, vhost, virtio, | | | |
| | | vmxnet3 | | | |
+-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | | descriptor | | af_packet, ark, avp, bnx2x, | v19.02 | b1b700ce7d6f | Replace descriptor_done API with |
+ | | status API | | bnxt, bonding, cxgbe, dpaa, | | | rx_descriptor_status and |
+ | | | dpaa2, ena, enic, | | | tx_descriptor_status APIs. |
+ | | | failsafe, fm10k, | | | |
+ | | | kni, liquidio, mlx4, | | | |
+ | | | mrvl, nfp, null, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, virtio, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
--
2.13.6
Mcnamara, John
2017-12-11 14:11:15 UTC
Permalink
-----Original Message-----
From: Yigit, Ferruh
Sent: Tuesday, November 21, 2017 1:43 AM
Subject: [PATCH 4/6] doc: add descriptor status API to PMD todo list
b1b700ce7d6f ("ethdev: add descriptor status API")
Proposed deadline for PMDs is v19.02
Acked-by: John McNamara <***@intel.com>
Ferruh Yigit
2017-11-21 01:42:40 UTC
Permalink
To track modification:
ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
cba7f53b717d ("ethdev: introduce Tx queue offloads API")

Proposed deadline for PMDs is v18.05

Signed-off-by: Ferruh Yigit <***@intel.com>
---
doc/guides/nics/todo.rst | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 9ace19716..61dd9cbc9 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -72,3 +72,14 @@ This is the list for tracking required PMD changes triggered by library modifica
| | | thunderx, vhost, virtio, | | | |
| | | vmxnet3 | | | |
+-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | new offload flags | | af_packet, ark, avp, bnx2x, | v18.05 | ce17eddefc20 | Use new ethdev offloads filed |
+ | | | bnxt, bonding, cxgbe, dpaa, | | cba7f53b717d | to get requested offload list |
+ | | | dpaa2, e1000, ena, enic, | | | instead of bitfield values. |
+ | | | failsafe, fm10k, i40e, ixgbe,| | | |
+ | | | kni, liquidio, mlx4, mlx5, | | | |
+ | | | mrvl, nfp, null, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, virtio, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
--
2.13.6
Shahaf Shuler
2017-11-21 08:32:52 UTC
Permalink
Hi Ferruh,
ce17eddefc20 ("ethdev: introduce Rx queue offloads API") cba7f53b717d
("ethdev: introduce Tx queue offloads API")
Proposed deadline for PMDs is v18.05
The deprecation of the old offloads API is set to 18.05 [1]. my understanding was that we agreed to convert all PMDs on 18.02.
If the PMD deadline is going to be postponed I think the ethdev deprecation should be updated.

[1] http://dpdk.org/doc/guides/rel_notes/deprecation.html
---
doc/guides/nics/todo.rst | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst index
9ace19716..61dd9cbc9 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -72,3 +72,14 @@ This is the list for tracking required PMD changes
triggered by library modifica
| | | thunderx, vhost, virtio, | | | |
| | | vmxnet3 | | | |
+-------------------+--------------------------------+----------+----------------+-------
----------------------------+
+ | new offload flags | | af_packet, ark, avp, bnx2x, | v18.05 |
ce17eddefc20 | Use new ethdev offloads filed |
+ | | | bnxt, bonding, cxgbe, dpaa, | | cba7f53b717d | to get
requested offload list |
+ | | | dpaa2, e1000, ena, enic, | | | instead of bitfield
values. |
+ | | | failsafe, fm10k, i40e, ixgbe,| | |
|
+ | | | kni, liquidio, mlx4, mlx5, | | | |
+ | | | mrvl, nfp, null, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, virtio, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+------
-----------------------------+
--
2.13.6
Ferruh Yigit
2017-11-21 18:02:33 UTC
Permalink
Post by Shahaf Shuler
Hi Ferruh,
ce17eddefc20 ("ethdev: introduce Rx queue offloads API") cba7f53b717d
("ethdev: introduce Tx queue offloads API")
Proposed deadline for PMDs is v18.05
The deprecation of the old offloads API is set to 18.05 [1]. my understanding was that we agreed to convert all PMDs on 18.02.
If the PMD deadline is going to be postponed I think the ethdev deprecation should be updated.
Hi Shahaf,

I put deadlines roughly and they need to be discussed here.

But 18.02 deadline is not far away.
I think it is not realistic to expect all relevant PMDs do this conversion on
time, what do you think?

My concern is if there can be some PMD maintainers just learned that an update
is required. I put these docs for that synchronization, but not sure how
efficient or noisy it will be.

Thanks,
ferruh
Post by Shahaf Shuler
[1] http://dpdk.org/doc/guides/rel_notes/deprecation.html
---
doc/guides/nics/todo.rst | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst index
9ace19716..61dd9cbc9 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -72,3 +72,14 @@ This is the list for tracking required PMD changes
triggered by library modifica
| | | thunderx, vhost, virtio, | | | |
| | | vmxnet3 | | | |
+-------------------+--------------------------------+----------+----------------+-------
----------------------------+
+ | new offload flags | | af_packet, ark, avp, bnx2x, | v18.05 |
ce17eddefc20 | Use new ethdev offloads filed |
+ | | | bnxt, bonding, cxgbe, dpaa, | | cba7f53b717d | to get
requested offload list |
+ | | | dpaa2, e1000, ena, enic, | | | instead of bitfield
values. |
+ | | | failsafe, fm10k, i40e, ixgbe,| | |
|
+ | | | kni, liquidio, mlx4, mlx5, | | | |
+ | | | mrvl, nfp, null, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, virtio, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+------
-----------------------------+
--
2.13.6
Shahaf Shuler
2017-11-22 08:43:31 UTC
Permalink
Post by Shahaf Shuler
Post by Shahaf Shuler
The deprecation of the old offloads API is set to 18.05 [1]. my
understanding was that we agreed to convert all PMDs on 18.02.
Post by Shahaf Shuler
If the PMD deadline is going to be postponed I think the ethdev
deprecation should be updated.
Hi Shahaf,
I put deadlines roughly and they need to be discussed here.
But 18.02 deadline is not far away.
I think it is not realistic to expect all relevant PMDs do this conversion on
time, what do you think?
I cannot tell about other vendors plans. For mlx4 and mlx5 I plan to convert on 18.02.
From the discussion we had on 17.11 for this feature we agreed to split it into 2, and the PMD part will be on 18.02. no one objected.

Maybe on the next Tech-board you can have a sync between some of the vendors to see the plans.
If not all can make it, we should postpone the deprecation of the old API.
Post by Shahaf Shuler
My concern is if there can be some PMD maintainers just learned that an
update is required. I put these docs for that synchronization, but not sure
how efficient or noisy it will be.
Thanks,
ferruh
Post by Shahaf Shuler
[1]
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd
k
.org%2Fdoc%2Fguides%2Frel_notes%2Fdeprecation.html&data=02%7C01%7
Cshah
afs%40mellanox.com%7Cd356ec7687fb4ef96d8608d5310a0c27%7Ca652971c7
d2e4d
9ba6a4d149256f461b%7C0%7C0%7C636468841603090882&sdata=cXeLzqmlly
nIg7xS
Post by Shahaf Shuler
zCIUJsHGFLHfA0LBdCWLv0%2B3Ko0%3D&reserved=0
Post by Ferruh Yigit
---
doc/guides/nics/todo.rst | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst index
9ace19716..61dd9cbc9 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -72,3 +72,14 @@ This is the list for tracking required PMD changes
triggered by library modifica
| | | thunderx, vhost, virtio, | | |
|
Post by Shahaf Shuler
Post by Ferruh Yigit
| | | vmxnet3 | | | |
+-------------------+--------------------------------+----------+----
------------+-------
----------------------------+
+ | new offload flags | | af_packet, ark, avp, bnx2x, | v18.05 |
ce17eddefc20 | Use new ethdev offloads filed |
+ | | | bnxt, bonding, cxgbe, dpaa, | | cba7f53b717d | to
get
Post by Shahaf Shuler
Post by Ferruh Yigit
requested offload list |
+ | | | dpaa2, e1000, ena, enic, | | | instead of
bitfield
Post by Shahaf Shuler
Post by Ferruh Yigit
values. |
+ | | | failsafe, fm10k, i40e, ixgbe,| | |
|
+ | | | kni, liquidio, mlx4, mlx5, | | |
|
Post by Shahaf Shuler
Post by Ferruh Yigit
+ | | | mrvl, nfp, null, octeontx, | | |
|
Post by Shahaf Shuler
Post by Ferruh Yigit
+ | | | pcap, qede, ring, sfc, | | |
|
Post by Shahaf Shuler
Post by Ferruh Yigit
+ | | | softnic, szedata2, tap, | | |
|
Post by Shahaf Shuler
Post by Ferruh Yigit
+ | | | thunderx, vhost, virtio, | | |
|
Post by Shahaf Shuler
Post by Ferruh Yigit
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+---
---
Post by Shahaf Shuler
Post by Ferruh Yigit
-----------------------------+
-
Thomas Monjalon
2017-11-22 08:54:19 UTC
Permalink
Post by Shahaf Shuler
Post by Shahaf Shuler
Post by Shahaf Shuler
The deprecation of the old offloads API is set to 18.05 [1]. my
understanding was that we agreed to convert all PMDs on 18.02.
Post by Shahaf Shuler
If the PMD deadline is going to be postponed I think the ethdev
deprecation should be updated.
Hi Shahaf,
I put deadlines roughly and they need to be discussed here.
But 18.02 deadline is not far away.
I think it is not realistic to expect all relevant PMDs do this conversion on
time, what do you think?
I cannot tell about other vendors plans. For mlx4 and mlx5 I plan to convert on 18.02.
From the discussion we had on 17.11 for this feature we agreed to split it into 2, and the PMD part will be on 18.02. no one objected.
Maybe on the next Tech-board you can have a sync between some of the vendors to see the plans.
If not all can make it, we should postpone the deprecation of the old API.
The current plan looks good to me.
We try to migrate to the new API in 18.02.
If some drivers are not migrated in 18.02, we urge them to do so in 18.05.
And we remove the old API in 18.05.
Mcnamara, John
2017-12-11 14:11:57 UTC
Permalink
-----Original Message-----
From: Yigit, Ferruh
Sent: Tuesday, November 21, 2017 1:43 AM
Subject: [PATCH 5/6] doc: add offload flag to PMD todo list
ce17eddefc20 ("ethdev: introduce Rx queue offloads API") cba7f53b717d
("ethdev: introduce Tx queue offloads API")
Proposed deadline for PMDs is v18.05
Acked-by: John McNamara <***@intel.com>
Ferruh Yigit
2017-11-21 01:42:41 UTC
Permalink
To track modification:
380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")

Proposed deadline for PMDs is v18.02

Signed-off-by: Ferruh Yigit <***@intel.com>
---
doc/guides/nics/todo.rst | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 61dd9cbc9..493a49ff2 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -83,3 +83,14 @@ This is the list for tracking required PMD changes triggered by library modifica
| | | thunderx, vhost, virtio, | | | |
| | | vmxnet3 | | | |
+-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | | check new mbuf | | af_packet, ark, avp, bnx2x, | v18.02 | 380a7aab1ae2 | mbuf flag PKT_RX_VLAN_PKT renamed |
+ | | VLAN flag | | bnxt, bonding, cxgbe, dpaa, | | | to PKT_RX_VLAN and its meaning |
+ | | PKT_RX_VLAN | | dpaa2, e1000, ena, enic, | | | changed, confirm PMD uses new |
+ | | | failsafe, fm10k, i40e, ixgbe,| | | flag correct. |
+ | | | kni, liquidio, mlx4, mlx5, | | | |
+ | | | mrvl, nfp, null, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, virtio, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
--
2.13.6
Ferruh Yigit
2017-11-21 01:53:32 UTC
Permalink
Post by Ferruh Yigit
380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
I recognized that almost all are by Olivier, cc'ed :)
Post by Ferruh Yigit
Proposed deadline for PMDs is v18.02
<...>
Hemant Agrawal
2017-12-06 09:24:50 UTC
Permalink
Post by Ferruh Yigit
380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
Proposed deadline for PMDs is v18.02
---
doc/guides/nics/todo.rst | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 61dd9cbc9..493a49ff2 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -83,3 +83,14 @@ This is the list for tracking required PMD changes triggered by library modifica
| | | thunderx, vhost, virtio, | | | |
| | | vmxnet3 | | | |
+-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | | check new mbuf | | af_packet, ark, avp, bnx2x, | v18.02 | 380a7aab1ae2 | mbuf flag PKT_RX_VLAN_PKT renamed |
+ | | VLAN flag | | bnxt, bonding, cxgbe, dpaa, | | | to PKT_RX_VLAN and its meaning |
+ | | PKT_RX_VLAN | | dpaa2, e1000, ena, enic, | | | changed, confirm PMD uses new |
+ | | | failsafe, fm10k, i40e, ixgbe,| | | flag correct. |
+ | | | kni, liquidio, mlx4, mlx5, | | | |
+ | | | mrvl, nfp, null, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, virtio, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
w.r.t dpaa and dpaa2
Reviewed-by: Hemant Agrawal <***@nxp.com>
Mcnamara, John
2017-12-11 14:16:43 UTC
Permalink
-----Original Message-----
From: Yigit, Ferruh
Sent: Tuesday, November 21, 2017 1:43 AM
Subject: [PATCH 6/6] doc: add mbuf VLAN flag to PMD todo list
380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
Proposed deadline for PMDs is v18.02
It might be worth putting | before all the text in the first column,
even if it is just a single item, since it will justify the text in
the same way.

Also it might be worth adding it to the text in the last column so
that the column isn't too wide.

Acked-by: John McNamara <***@intel.com>
Andrew Rybchenko
2017-12-29 11:50:14 UTC
Permalink
Post by Ferruh Yigit
380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
Proposed deadline for PMDs is v18.02
---
doc/guides/nics/todo.rst | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 61dd9cbc9..493a49ff2 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -83,3 +83,14 @@ This is the list for tracking required PMD changes triggered by library modifica
| | | thunderx, vhost, virtio, | | | |
| | | vmxnet3 | | | |
+-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | | check new mbuf | | af_packet, ark, avp, bnx2x, | v18.02 | 380a7aab1ae2 | mbuf flag PKT_RX_VLAN_PKT renamed |
+ | | VLAN flag | | bnxt, bonding, cxgbe, dpaa, | | | to PKT_RX_VLAN and its meaning |
+ | | PKT_RX_VLAN | | dpaa2, e1000, ena, enic, | | | changed, confirm PMD uses new |
+ | | | failsafe, fm10k, i40e, ixgbe,| | | flag correct. |
+ | | | kni, liquidio, mlx4, mlx5, | | | |
+ | | | mrvl, nfp, null, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, virtio, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
sfc may be excluded from the list since neither old nor new flag is used.
Of course, I can send a patch to remove it, if required.
Stephen Hemminger
2017-12-29 17:09:25 UTC
Permalink
On Tue, 21 Nov 2017 01:42:41 +0000
Post by Ferruh Yigit
380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
Proposed deadline for PMDs is v18.02
---
doc/guides/nics/todo.rst | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 61dd9cbc9..493a49ff2 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -83,3 +83,14 @@ This is the list for tracking required PMD changes triggered by library modifica
| | | thunderx, vhost, virtio, | | | |
| | | vmxnet3 | | | |
+-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | | check new mbuf | | af_packet, ark, avp, bnx2x, | v18.02 | 380a7aab1ae2 | mbuf flag PKT_RX_VLAN_PKT renamed |
+ | | VLAN flag | | bnxt, bonding, cxgbe, dpaa, | | | to PKT_RX_VLAN and its meaning |
+ | | PKT_RX_VLAN | | dpaa2, e1000, ena, enic, | | | changed, confirm PMD uses new |
+ | | | failsafe, fm10k, i40e, ixgbe,| | | flag correct. |
+ | | | kni, liquidio, mlx4, mlx5, | | | |
+ | | | mrvl, nfp, null, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, virtio, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
NAK
Fix the other drivers.

This open source, if you introduce a new behavior it is the responsibility of the person adding
the new stuff to fix every other driver.
Olivier Matz
2018-01-03 14:14:00 UTC
Permalink
Post by Stephen Hemminger
On Tue, 21 Nov 2017 01:42:41 +0000
Post by Ferruh Yigit
380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
Proposed deadline for PMDs is v18.02
---
doc/guides/nics/todo.rst | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst
index 61dd9cbc9..493a49ff2 100644
--- a/doc/guides/nics/todo.rst
+++ b/doc/guides/nics/todo.rst
@@ -83,3 +83,14 @@ This is the list for tracking required PMD changes triggered by library modifica
| | | thunderx, vhost, virtio, | | | |
| | | vmxnet3 | | | |
+-------------------+--------------------------------+----------+----------------+-----------------------------------+
+ | | check new mbuf | | af_packet, ark, avp, bnx2x, | v18.02 | 380a7aab1ae2 | mbuf flag PKT_RX_VLAN_PKT renamed |
+ | | VLAN flag | | bnxt, bonding, cxgbe, dpaa, | | | to PKT_RX_VLAN and its meaning |
+ | | PKT_RX_VLAN | | dpaa2, e1000, ena, enic, | | | changed, confirm PMD uses new |
+ | | | failsafe, fm10k, i40e, ixgbe,| | | flag correct. |
+ | | | kni, liquidio, mlx4, mlx5, | | | |
+ | | | mrvl, nfp, null, octeontx, | | | |
+ | | | pcap, qede, ring, sfc, | | | |
+ | | | softnic, szedata2, tap, | | | |
+ | | | thunderx, vhost, virtio, | | | |
+ | | | vmxnet3 | | | |
+ +-------------------+--------------------------------+----------+----------------+-----------------------------------+
NAK
Fix the other drivers.
This open source, if you introduce a new behavior it is the responsibility of the person adding
the new stuff to fix every other driver.
Actually, no new behavior was introduced. The meaning of the vlan flags
has been clarified. The purpose of this note is to ask the maintainers
to ensure that the behavior of the PMDs matches the API. This operation
is not easy to do for someone that does not know the hardware, and
that cannot test it.

Mcnamara, John
2017-12-11 11:52:29 UTC
Permalink
-----Original Message-----
From: Yigit, Ferruh
Sent: Tuesday, November 21, 2017 1:43 AM
Subject: [PATCH 1/6] doc: add empty PMDs todo list
Some library modifications require extra checks or modifications in PMDs
but currently we don't have a good way to trace these modifications.
And number of these kind of updates increasing by time.
This is an effort to document and track library updates that requires
attention in PMDs.
Although this is under documentation main use case is for internal
development.
...
+PMDs internal TODO list
+=======================
+
+This is the list for tracking required PMD changes triggered by library modifications.
+
+.. table:: PMDs internal TODO list
+
+ +------+------+----------+----------------+------+
+ | TODO | PMDs | Deadline | Related Commit | Note |
+ +======+======+==========+================+======+
+ | | | | | |
+ +------+------+----------+----------------+------+
The table should have a label, and it should be indented to the level of .. table
as shown in the guidelines: http://dpdk.org/doc/guides/contributing/documentation.html#rst-guidelines

Something like this:

.. _table_nic_todo:

.. table:: PMDs internal TODO list

+------+------+----------+----------------+------+
| TODO | PMDs | Deadline | Related Commit | Note |
+======+======+==========+================+======+
| | | | | |
+------+------+----------+----------------+------+

However, it isn't an error so:


Acked-by: John McNamara <***@intel.com>
Continue reading on narkive:
Loading...