Discussion:
[dpdk-dev] [PATCH] test/metrics: Fixed a negative case to pass
(too old to reply)
Harman Kalra
2018-12-06 15:01:22 UTC
Permalink
Negative test case for passing invalid count size to
rte_metrics_update_values() will pass if count value
is any value greater than 1 because set size wrt to
key id 1 is 1 and passing 0 as no of values to be
updated will not hit the ERANGE check.

Signed-off-by: Harman Kalra <***@marvell.com>
---
test/test/test_metrics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git test/test/test_metrics.c test/test/test_metrics.c
index 94d54d71c..3c2f36b8a 100644
--- test/test/test_metrics.c
+++ test/test/test_metrics.c
@@ -154,7 +154,7 @@ test_metrics_update_values(void)

/* Failed Test: Invalid count size */
err = rte_metrics_update_values(RTE_METRICS_GLOBAL,
- KEY, &value[0], 0);
+ KEY, &value[0], ARRAY_SIZE(value));
TEST_ASSERT(err < 0, "%s, %d", __func__, __LINE__);

/* Failed Test: Invalid port_id(lower value) and valid data */
--
2.18.0
Remy Horton
2018-12-07 11:45:21 UTC
Permalink
Git apply choked on the patch but it applied using patch -p0 - I'm
guessing this is a problem with patches made using diff rather than git
format-patch. The change itself is fine though. :)
Post by Harman Kalra
Negative test case for passing invalid count size to
rte_metrics_update_values() will pass if count value
is any value greater than 1 because set size wrt to
key id 1 is 1 and passing 0 as no of values to be
updated will not hit the ERANGE check.
Missing fixline:

Fixes: cd3804242901 ("test/metrics: add unit tests for metrics library")

Acked-by: Remy Horton <***@intel.com>
Harman Kalra
2018-12-10 08:44:33 UTC
Permalink
Negative test case for passing invalid count size to
rte_metrics_update_values() will pass if count value
is any value greater than 1 because set size wrt to
key id 1 is 1 and passing 0 as no of values to be
updated will not hit the ERANGE check.

Signed-off-by: Harman Kalra <***@marvell.com>
---
Fixed the patch creation issue, now git apply works fine.

test/test/test_metrics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/test/test_metrics.c b/test/test/test_metrics.c
index 94d54d71c..3c2f36b8a 100644
--- a/test/test/test_metrics.c
+++ b/test/test/test_metrics.c
@@ -154,7 +154,7 @@ test_metrics_update_values(void)

/* Failed Test: Invalid count size */
err = rte_metrics_update_values(RTE_METRICS_GLOBAL,
- KEY, &value[0], 0);
+ KEY, &value[0], ARRAY_SIZE(value));
TEST_ASSERT(err < 0, "%s, %d", __func__, __LINE__);

/* Failed Test: Invalid port_id(lower value) and valid data */
--
2.18.0
Harman Kalra
2018-12-10 08:39:15 UTC
Permalink
Negative test case for passing invalid count size to
rte_metrics_update_values() will pass if count value
is any value greater than 1 because set size wrt to
key id 1 is 1 and passing 0 as no of values to be
updated will not hit the ERANGE check.

Signed-off-by: Harman Kalra <***@marvell.com>
---
Fixed the patch creation issue, now git apply works fine.

test/test/test_metrics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/test/test_metrics.c b/test/test/test_metrics.c
index 94d54d71c..3c2f36b8a 100644
--- a/test/test/test_metrics.c
+++ b/test/test/test_metrics.c
@@ -154,7 +154,7 @@ test_metrics_update_values(void)

/* Failed Test: Invalid count size */
err = rte_metrics_update_values(RTE_METRICS_GLOBAL,
- KEY, &value[0], 0);
+ KEY, &value[0], ARRAY_SIZE(value));
TEST_ASSERT(err < 0, "%s, %d", __func__, __LINE__);

/* Failed Test: Invalid port_id(lower value) and valid data */
--
2.18.0
Loading...